Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor changes in StoreCore #1241

Merged
merged 1 commit into from
Apr 22, 2024
Merged

chore: minor changes in StoreCore #1241

merged 1 commit into from
Apr 22, 2024

Conversation

arthurpaulino
Copy link
Member

  • Factor out common code for finalizing interning
  • Make intern_digest just return usize
  • Improve some docstrings

@arthurpaulino
chore: minor changes in StoreCore
4bd17be 
* Factor out common code for finalizing interning
* Make `intern_digest` just return `usize`
* Improve some docstrings
@arthurpaulino arthurpaulino marked this pull request as ready for review April 18, 2024 23:00
@arthurpaulino arthurpaulino requested a review from a team as a code owner April 18, 2024 23:00
huitseeker
huitseeker approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@arthurpaulino arthurpaulino added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 8802da5 Apr 22, 2024
16 of 22 checks passed
@arthurpaulino arthurpaulino deleted the ap/minor-store-core-changes branch April 22, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arthurpaulino @huitseeker