Implement comparisons in the circuit #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
reviewed
Sep 23, 2022
porcuquine
reviewed
Sep 23, 2022
porcuquine
reviewed
Sep 23, 2022
porcuquine
reviewed
Sep 23, 2022
porcuquine
reviewed
Oct 8, 2022
porcuquine
reviewed
Oct 8, 2022
porcuquine
reviewed
Oct 10, 2022
porcuquine
reviewed
Oct 10, 2022
porcuquine
reviewed
Oct 10, 2022
src/circuit/circuit_frame.rs
Outdated
|
|
||
| let diff_is_negative_or_zero = constraints::or( | ||
| &mut cs.namespace(|| "diff is negative or zero"), | ||
| lsb_2diff.unwrap(), |
There was a problem hiding this comment.
We should use diff_is_negative here, since we (rightly) bothered creating this clarifying binding.
There was a problem hiding this comment.
To minimize cognitive load, I would get rid of these 'or_zero' names and standardize on a simpler convention. I would call this diff_is_not_positive.
porcuquine
reviewed
Oct 10, 2022
porcuquine
reviewed
Oct 10, 2022
porcuquine
reviewed
Oct 10, 2022
porcuquine
reviewed
Oct 10, 2022
porcuquine
reviewed
Oct 10, 2022
porcuquine
reviewed
Oct 11, 2022
porcuquine
reviewed
Oct 11, 2022
porcuquine
reviewed
Oct 11, 2022
porcuquine
reviewed
Oct 11, 2022
porcuquine
previously approved these changes
Oct 11, 2022
|
I restarted CI because the mac job timed out. That and the arm64 job have both become very slow. We should try to figure out why that is, and hopefully address it. That doesn't seem to be so on |
johnchandlerburnham
pushed a commit
that referenced
this pull request
Nov 8, 2022
* Comparison of a and b Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comparisons to the circuit. In order to do that I have refactored
multi_caseto returnis_default, because it allows to avoid repeated constraints.