Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors during evaluation #144

Merged
merged 7 commits into from
Sep 28, 2022
Merged

Handle errors during evaluation #144

merged 7 commits into from
Sep 28, 2022

Conversation

samuelburnham
Copy link
Member

No description provided.

@samuelburnham samuelburnham marked this pull request as ready for review September 27, 2022 21:46
porcuquine
porcuquine previously approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@porcuquine porcuquine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, and CI is failing. I think the macro needs to be update. Once CI is green, this is good to go.

@porcuquine porcuquine merged commit d83e077 into master Sep 28, 2022
@porcuquine porcuquine deleted the sb/eval-errors branch September 28, 2022 23:49
This was referenced Sep 29, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcuquine porcuquine porcuquine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelburnham @porcuquine