Support modulo operator for u64. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmorais
approved these changes
Nov 5, 2022
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Jan 23, 2023
This aligns the behavior of mod with that of div, see lurk-lab#166 for the original inclusion of mod. Fixes lurk-lab#197
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Jan 23, 2023
This aligns the behavior of mod with that of div, see lurk-lab#166 for the original inclusion of mod. Fixes lurk-lab#197
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Jan 23, 2023
This aligns the behavior of mod with that of div, see lurk-lab#166 for the original inclusion of mod. Fixes lurk-lab#197
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Jan 24, 2023
This aligns the behavior of mod with that of div, see lurk-lab#166 for the original inclusion of mod. Fixes lurk-lab#197
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Jan 24, 2023
This aligns the behavior of mod with that of div, see lurk-lab#166 for the original inclusion of mod. Fixes lurk-lab#197
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Jan 25, 2023
This aligns the behavior of mod with that of div, see lurk-lab#166 for the original inclusion of mod. Fixes lurk-lab#197
huitseeker
added a commit
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have
U64, supporting mod is easy. The implementation assumes that both args areU64and returns aU64.This PR also adds some missing tests showing that it is an error to apply a numeric operator to a non-numeric argument. These should be ported to the circuit, since explicit proof of error conditions needs to be tested.