Don't exit REPL on runtime error. #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2023
porcuquine
force-pushed
the
repl-err-gracefully
branch
from
fd3a440
to
f79db9d
Compare
huitseeker
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
The way you have phrased the PR summary might close #178 automatically upon merge, beware.
|
Heh, you're right. I'll reopen it manually after merging. I thought the magic words had to come first. |
emmorais
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes the placeholder, #217. Now runtime errors during the E(valuation) part of the REPL don't break the L(oop).
Although this does fix #178 in the literal sense, the underlying problem is related to Lurk-level error-handling, so let's not close it with this.