match supernova::Proof::verify to nova::Proof::verify

[mpenciak]

This PR addresses #695 by matching the nova::Proof::verify implementaton.

Do not merge until PR #72 in Arecibo is merged, and the cargo.toml change can be reverted.

[porcuquine]

I approved this, pending the mechanical changes to merge based on arecibo#72 noted in the description.

[huitseeker]

You should not need this clone. Here's one way to make this work:

        let zi_secondary = &z0_secondary;

        let (zi_primary_verified, zi_secondary_verified) = match self {
            Self::Recursive(p) => p.verify(&pp.pp, circuit_index, z0_primary, &z0_secondary),
            Self::Compressed(_) => unimplemented!(),
        }?;

        Ok(zi_primary == zi_primary_verified && *zi_secondary == zi_secondary_verified)

[arthurpaulino]

Oh, we have a similar case in nova.rs:

lurk-rs/src/proof/nova.rs

Line 514 in e4f634c

let zi_secondary = z0_secondary.clone();

[huitseeker]

Oh! @mpenciak are you up for seeing if the same fix applies?

[mpenciak]

Unfortunately the same fix doesn't work in nova.rs because the Self::Compressed branch takes ownership of z0_secondary...

(we may actually end up needing to re-add in the clone after the compressed version for supernova is added in for the same reason)

[arthurpaulino]

Ah, then it's a matter of time until we need to clone it anyway