Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire Lurk alpha proving + benchmarks #873

Merged
merged 4 commits into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/bench-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Install criterion
run: cargo install cargo-criterion
- name: Run benchmarks
run: just --dotenv-filename bench.env gpu-bench fibonacci_lem
run: just --dotenv-filename bench.env gpu-bench fibonacci
working-directory: ${{ github.workspace }}/benches
# TODO: Prettify labels for easier viewing
# Compress the benchmark file and metadata for later analysis
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/bench-pr-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- uses: boa-dev/criterion-compare-action@v3
with:
# Optional. Compare only this benchmark target
benchName: "fibonacci_lem"
benchName: "fibonacci"
# Needed. The name of the branch to compare with
branchName: ${{ github.ref_name }}

Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
with:
# Note: Removing `benchName` causes `criterion` errors: https://github.com/boa-dev/criterion-compare-action#troubleshooting
# Optional. Compare only this benchmark target
benchName: "fibonacci_lem"
benchName: "fibonacci"
# Optional. Features activated in the benchmark
features: "cuda"
# Needed. The name of the branch to compare with
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gpu-bench-workflow-dispatch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Set bench output format type
run: echo "LURK_BENCH_OUTPUT=commit-comment" | tee -a $GITHUB_ENV
- name: Run GPU bench on branch
run: just --dotenv-filename bench.env gpu-bench fibonacci_lem
run: just --dotenv-filename bench.env gpu-bench fibonacci
working-directory: ${{ github.workspace }}/benches
- name: copy the benchmark template and prepare it with data
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/merge-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,15 @@ jobs:
- name: Set bench output format type
run: echo "LURK_BENCH_OUTPUT=commit-comment" | tee -a $GITHUB_ENV
- name: Run GPU bench on base branch
run: just --dotenv-filename bench.env gpu-bench fibonacci_lem
run: just --dotenv-filename bench.env gpu-bench fibonacci
working-directory: ${{ github.workspace }}/master/benches
- name: Copy bench output to PR branch
run: |
mkdir -p target
cp -r master/target/criterion target
cp master/${{ env.BASE_REF }}.json .
- name: Run GPU bench on PR branch
run: just --dotenv-filename bench.env gpu-bench fibonacci_lem
run: just --dotenv-filename bench.env gpu-bench fibonacci
working-directory: ${{ github.workspace }}/benches
- name: copy the benchmark template and prepare it with data
run: |
Expand Down
16 changes: 0 additions & 16 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -165,34 +165,18 @@ debug-assertions = false
name = "end2end"
harness = false

[[bench]]
name = "end2end_lem"
harness = false

[[bench]]
name = "fibonacci"
harness = false

[[bench]]
name = "fibonacci_lem"
harness = false

[[bench]]
name = "synthesis"
harness = false

[[bench]]
name = "synthesis_lem"
harness = false

[[bench]]
name = "sha256"
harness = false

[[bench]]
name = "sha256_lem"
harness = false

[[bench]]
name = "public_params"
harness = false
Expand Down
Loading
Loading