Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neptune uses an outdated reference script #162

Closed
themighty1 opened this issue Aug 29, 2022 · 1 comment
Closed

Neptune uses an outdated reference script #162

themighty1 opened this issue Aug 29, 2022 · 1 comment

Comments

@themighty1
Copy link
Contributor

Hi, fn generate_constants() https://github.com/filecoin-project/neptune/blob/2b11f0ce69f52aa9594f250baa658bfe2d349ac3/src/round_constants.rs#L26
references https://extgit.iaik.tugraz.at/krypto/hadeshash/blob/master/code/scripts/create_rcs_grain.sage
That file does not exist. An updated script exists in that repo with a notice of some fixed bugs.

Are there no security implications in not following the updated reference impl?

I was trying to reproduce the Poseidon constants which circomlib uses (they use the more recent script generate_parameters_grain.sage) and was unable to.

@themighty1 themighty1 changed the title Neptune uses an outdated reference script Neptunes constants don't match the reference script Aug 30, 2022
@themighty1 themighty1 changed the title Neptunes constants don't match the reference script Neptune uses an outdated reference script Aug 30, 2022
@themighty1
Copy link
Contributor Author

I was able to confirm that the old script generates the same parameters as the new one. Created a PR #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant