Remove hardcoded JSONs #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storojs72
changed the title
|
!test |
storojs72
requested review from
samuelburnham and
wwared
and removed request for
wwared
samuelburnham
approved these changes
Feb 20, 2024
|
Important note is that for executing integration tests in custom branches, |
storojs72
changed the title
samuelburnham
pushed a commit
to samuelburnham/solidity-verifier
that referenced
this pull request
Feb 20, 2024
* Remove hardcoded JSONs * Update CI configuration * Drop end2end.yml as it is not relevant for custom branches
samuelburnham
pushed a commit
to samuelburnham/solidity-verifier
that referenced
this pull request
Feb 20, 2024
* Remove hardcoded JSONs * Update CI configuration * Drop end2end.yml as it is not relevant for custom branches
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Automatic generating of proof / public parameters JSONs (#53) * added CI scrypt for generating pk and compression-snark from Nova repo commit * Changed CI e2e configuration to work with NOVA_URL and NOVA_COMMIT params. Python script changed to work with any version of nova commit. PS: Previous test on nova/src/lib.rs can be removed. * Changed Script name. Return back from generating test in runtime * Changed Script name. Return back from generating test in runtime * Changed Script and CI config. --------- Co-authored-by: Artem <asamblers@gmail.com> * Remove hardcoded JSONs (#54) * Remove hardcoded JSONs * Update CI configuration * Drop end2end.yml as it is not relevant for custom branches * ci: Configure `!test` comment * Address feedback --------- Co-authored-by: artem-bakuta <47213324+artem-bakuta@users.noreply.github.com> Co-authored-by: Artem <asamblers@gmail.com> Co-authored-by: Artem Storozhuk <storojs72@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a companion to #53.
Here we want to check how input JSONs generated automatically will work for pasta contract