Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded JSONs #54

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Remove hardcoded JSONs #54

merged 3 commits into from
Feb 20, 2024

Conversation

storojs72
Copy link
Member

This PR is a companion to #53.

Here we want to check how input JSONs generated automatically will work for pasta contract

@storojs72 storojs72 changed the title Test contract input JSONs autogenering Test contract input JSONs autogenerating Feb 20, 2024
@storojs72
Copy link
Member Author

!test

@storojs72 storojs72 requested review from samuelburnham and wwared and removed request for wwared February 20, 2024 14:33
@storojs72
Copy link
Member Author

Important note is that for executing integration tests in custom branches, end2end.yml is taken from main branch, because issue_comment workflows always trigger with the workflow file that exists on the default branch (main)

@storojs72 storojs72 changed the title Test contract input JSONs autogenerating Remove hardcoded JSONs Feb 20, 2024
@storojs72 storojs72 merged commit 26e4310 into pasta Feb 20, 2024
1 check passed
@storojs72 storojs72 deleted the pasta-merge branch February 20, 2024 15:56
samuelburnham pushed a commit to samuelburnham/solidity-verifier that referenced this pull request Feb 20, 2024
* Remove hardcoded JSONs

* Update CI configuration

* Drop end2end.yml as it is not relevant for custom branches
samuelburnham pushed a commit to samuelburnham/solidity-verifier that referenced this pull request Feb 20, 2024
* Remove hardcoded JSONs

* Update CI configuration

* Drop end2end.yml as it is not relevant for custom branches
github-merge-queue bot pushed a commit that referenced this pull request Feb 20, 2024
* Automatic generating of proof / public parameters JSONs (#53)

* added CI scrypt for generating pk and compression-snark from Nova repo commit

* Changed CI e2e configuration to work with NOVA_URL and NOVA_COMMIT params. Python script changed to work with any version of nova commit.
PS: Previous test on nova/src/lib.rs can be removed.

* Changed Script name. Return back from generating test in runtime

* Changed Script name. Return back from generating test in runtime

* Changed Script and CI config.

---------

Co-authored-by: Artem <asamblers@gmail.com>

* Remove hardcoded JSONs (#54)

* Remove hardcoded JSONs

* Update CI configuration

* Drop end2end.yml as it is not relevant for custom branches

* ci: Configure `!test` comment

* Address feedback

---------

Co-authored-by: artem-bakuta <47213324+artem-bakuta@users.noreply.github.com>
Co-authored-by: Artem <asamblers@gmail.com>
Co-authored-by: Artem Storozhuk <storojs72@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants