Basic Emojivision App #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
lusbenjamin
commented
Aug 19, 2017
lusbenjamin
commented
lusbenjamin
commented
Aug 19, 2017
.circleci/config.yml
Outdated
| - deploy: | ||
| name: maybe deploy | ||
| command: | | ||
| if [ "${CIRCLE_BRANCH}" == "master" ]; then | ||
| if [ "${CIRCLE_BRANCH}" == "basic-form" ]; then |
There was a problem hiding this comment.
TODO: put this back to "master"
avoids naming conflict and faster to type
centralized constants file
lusbenjamin
force-pushed
the
basic-form
branch
2 times, most recently
from
17fe32b
to
5a7e577
Compare
lusbenjamin
force-pushed
the
basic-form
branch
from
5a7e577
to
255e368
Compare
lusbenjamin
commented
Aug 20, 2017
| app.config['SECRET_KEY'] = 'so-so-secret' # change this | ||
| # IMPORTANT: be extremely careful with config['TRAP_HTTP_EXCEPTIONS'] | ||
| # Setting to True will break Google App Engine load balancers!!! | ||
| # (this probably has to do with GAE expecting a 404 at /_ah/healthcheck) |
There was a problem hiding this comment.
^ this comment represents almost 48 hours of debugging
😞
|
@melodylu FINALLY got this to work on Google App Engine. Going to go ahead and merge this before we review it, but would love to revisit this in detail later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.