Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breakpad-symbols: Add a bandwidth/time limit to symbol downloading #300

Closed
Gankra opened this issue Nov 18, 2021 · 1 comment · Fixed by #301
Closed

breakpad-symbols: Add a bandwidth/time limit to symbol downloading #300

Gankra opened this issue Nov 18, 2021 · 1 comment · Fixed by #301

Comments

@Gankra
Copy link
Collaborator

Gankra commented Nov 18, 2021

Deploying to mozilla's staging servers, a couple minidumps timed out because the .sym file download from AWS was infinite(???). Navigating to the URL I can confirm that firefox also is completely baffled by these URLs. We need some way for the symbol downloader to give up on symbols files that act like this and proceed on without it.
@Gankra
Copy link
Collaborator Author

Gankra commented Nov 18, 2021

Assuming there's no easy way to just "see" that the download is messed up, it's possible we can just set timeout on Client: https://docs.rs/reqwest/0.9.18/reqwest/struct.ClientBuilder.html#method.timeout

But I'm not actually sure if this will do what we want, since technically we're making forward progress in the download? I guess I'll just try it and see.

Gankra added a commit to Gankra/rust-minidump that referenced this issue Nov 18, 2021
@Gankra
Add a timeout to symbol downloads
fc3c91c 
The number I picked here is kinda arbitrary.

Fixes rust-minidump#300
@Gankra Gankra mentioned this issue Nov 18, 2021
Merged
Gankra added a commit to Gankra/rust-minidump that referenced this issue Nov 18, 2021
@Gankra
Add a timeout to symbol downloads
df1b200 
This also introduces a --symbol-download-timeout-secs flag to minidump-stackwalk
so it's configurable. The default is 1000 seconds (which for a 300MB .sym file
requires a connection speed of 300KB/s).

Weirdly I think adding the timeout at all seems to unstick the download, but I'm
not sure. Either way you can tune the value to your needs.

Fixes rust-minidump#300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a timeout to symbol downloads Gankra/rust-minidump
1 participant
@Gankra