Add a timeout to symbol downloads #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Surprisingly this timeout not only unblocks mdsw, but it also successfully resolves the file?? Maybe we're getting a truncated version or it just gets loopy at the EOF. Either way we manage to parse the symbols and run the cfi, which is neat. |
I love it when things work and we don't know why 😏 |
This also introduces a --symbol-download-timeout-secs flag to minidump-stackwalk so it's configurable. The default is 1000 seconds (which for a 300MB .sym file requires a connection speed of 300KB/s). Weirdly I think adding the timeout at all seems to unstick the download, but I'm not sure. Either way you can tune the value to your needs. Fixes rust-minidump#300
|
New version, more robust, more confusing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also introduces a --symbol-download-timeout-secs flag to minidump-stackwalk
so it's configurable. The default is 1000 seconds (which for a 300MB .sym file
requires a connection speed of 300KB/s).
Weirdly I think adding the timeout at all seems to unstick the download, but I'm
not sure. Either way you can tune the value to your needs.
Fixes #300