[Issue #165] Fixing palettes. Again. #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…characters are not actually changing classes. Updated logic to always strip out duplicate colors from the list of reference colors. Fixed some minor issues with color indices in FE8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #165 - Added logic to not do unnecessary work by not generating palettes if characters are not actually changing classes. This should resolve issues where characters have new palettes even if their class has not changed.
Additionally, I updated the logic to always strip out duplicate colors from the list of reference colors. This should result in better color choices in most cases. There were also some minor issues with color indices in FE8 (specifically in the lord palettes and Paladin). There might be more, but we can tackle them as they come.
Also to help, changelogs now have a debug section for palette changes at the end of the log, with colors and their RGB values used.