Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments support #51

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Comments support #51

merged 3 commits into from
Oct 12, 2020

Conversation

w00lf
Copy link
Contributor

@w00lf w00lf commented Oct 12, 2020

#11 support for one line and multiline comments lutaml, specs, examples


it "create comments for document and classes" do
expect(parse.comments).to(eq(["My comment",
"this is multiline\n comment with {} special\n chars/\n\n +-|/"]))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [113/80]

spaces? >> str("**") >> (newline.absent? >> any).repeat.as(:comments)
end
rule(:comment_multiline_definition) do
spaces? >> str("*|") >> (str("|*").absent? >> any).repeat.as(:comments) >> whitespace? >> str("|*")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [109/80]

@w00lf w00lf requested a review from ronaldtse October 12, 2020 13:44
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @w00lf!

@w00lf w00lf merged commit 8df2533 into master Oct 12, 2020
@ronaldtse ronaldtse deleted the feature/dsl-comments branch October 12, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants