Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check default time units in selafin files #185

Closed
PeterPetrik opened this issue Dec 13, 2019 · 2 comments
Closed

Check default time units in selafin files #185

PeterPetrik opened this issue Dec 13, 2019 · 2 comments
Labels
formats formats/providers question Further information is requested

Comments

@PeterPetrik
Copy link
Contributor

http://www.opentelemac.org/downloads/Archive/v6p0/telemac2d_user_manual_v6p0.pdf
is not specific whether time is in hours or seconds,

Appendix 3: page 118: 
Next, for each time step, the following are found:-  1 record containing time T (real),

so far we are parsing this time as hours.

@ccoulet do you know if timesteps in QGIS are correct, or the default is hours and the timesteps are not as in other softwares?
@PeterPetrik PeterPetrik added question Further information is requested formats formats/providers regression labels Dec 13, 2019
@PeterPetrik
Copy link
Contributor Author

PeterPetrik commented Dec 13, 2019 •
edited
Loading

#179 changed it to seconds, so I reverted it back to hours to not introduce regression in 7a2665e

PeterPetrik added a commit that referenced this issue Dec 13, 2019
@PeterPetrik
revert selafin default timeunit to hours to not introduce regression …
7a2665e 
…see #185
@ccoulet
Copy link
Contributor

ccoulet commented Dec 13, 2019

Hi
Time in telemac selafin file is in seconds.
It's wrong in QGIS
regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
formats formats/providers question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PeterPetrik @ccoulet