Xmdf support #11
Merged
Xmdf support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
reviewed
May 24, 2018
mdal/frmts/mdal_hdf5.hpp
Outdated
| #ifndef MDAL_HDF5_HPP | ||
| #define MDAL_HDF5_HPP | ||
|
|
||
| /** A simple C++/Qt wrapper around HDF5 library API */ |
mdal/frmts/mdal_hdf5.hpp
Outdated
| return data; | ||
| } | ||
|
|
||
| float readFloat() |
mdal/frmts/mdal_xmdf.cpp
Outdated
| if ( ds.size() != 1 ) | ||
| MDAL::debug( "Maximum dataset should have just one timestep!" ); | ||
| else | ||
| datasets.push_back( ds.at( 0 ) ); |
There was a problem hiding this comment.
should use emplace_back instead of push_back for c++11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10
Copied from crayfish with removal of Qt