Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide client library to simplify communication with the renderer #5

Closed
luttje opened this issue Feb 26, 2023 · 1 comment · Fixed by #9
Closed

Provide client library to simplify communication with the renderer #5

luttje opened this issue Feb 26, 2023 · 1 comment · Fixed by #9
Labels
enhancement New feature or request

Comments

@luttje
Copy link
Owner

luttje commented Feb 26, 2023

Right now, in order to build a video app some messaging has to occur between the video app and renderer as shown in this example. This communication protocol should happen through an interface. That way consumers do not have to worry about the protocol inevitably changing.

I'm thinking a Typescript package that compiles to a ES module and exports type defintions for TS users.

-outdated psuedo code removed-

@luttje luttje added the enhancement New feature or request label Feb 26, 2023
luttje added a commit that referenced this issue Feb 26, 2023
@luttje luttje changed the title Provide Typescript core to simplify communication with the renderer Provide client library to simplify communication with the renderer Feb 27, 2023
@luttje luttje linked a pull request Feb 27, 2023 that will close this issue
14 tasks
@luttje
Copy link
Owner Author

luttje commented Feb 27, 2023

I expect that there are conditions where the postMessage sent by the renderer can be delayed and cause a screenshot to be taken too soon. It hasn't happened yet, but there's nothing in the code to suggest it should be synchronous.

Playwright can directly await async evaluated functions before taking the screenshot just fine. We should implement this somehow to improve stability.

luttje added a commit that referenced this issue Feb 27, 2023
@luttje luttje closed this as completed in #9 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant