Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gap between </ul> and <div> in tabbed maps #37

Closed
stangri opened this issue Mar 8, 2017 · 2 comments
Closed

Gap between </ul> and <div> in tabbed maps #37

stangri opened this issue Mar 8, 2017 · 2 comments

Comments

@stangri
Copy link

stangri commented Mar 8, 2017

This theme seems to have a bug with tabbed maps (m.tabbed = true) as evidenced by the screenshot. This gap between tabs and their content is not present in the bootstrap theme and as a workaround I've used the modified map template (line 13: <ul class="cbi-tabmenu map" style="margin-bottom:-32px;"> and removed the <br />) which is an ugly fix.
screen shot 2017-03-08 at 13 30 42

I do not have enough HTML5/CSS skills to hunt down the bug tho, hopefully someone more knowledgeable will.

@LuttyYang
Copy link
Owner

I don't known where this page is, please tell me where can find this page~

@stangri
Copy link
Author

stangri commented May 2, 2017

This screenshot is from luci-app-openvpn-policy-routing. I have now used a custom map file which fixes a bug in your theme. If you want to reproduce the bug, install luci-app-openvpn-policy-routing from https://stangri.github.io/openwrt-repo/ and change line 78 of /usr/lib/lua/luci/model/cbi/openvpn-policy-routing.lua file to:
p.template="cbi/map"

@stangri stangri closed this as completed Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants