Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVINO support #191

Closed
12 tasks done
lutzroeder opened this issue Nov 22, 2018 · 14 comments
Closed
12 tasks done

OpenVINO support #191

lutzroeder opened this issue Nov 22, 2018 · 14 comments
Labels

Comments

@lutzroeder
Copy link
Owner

lutzroeder commented Nov 22, 2018

2018_R3_age-gender-recognition-retail-0013.zip
2018_R3_rm_lstm4f.zip
2018_R4_landmarks-regression-retail-0009-fp16.zip
2018_R4_single-image-super-resolution-0034.xml.zip
2018_R5_vehicle-license-plate-detection-barrier-0106.xml.zip
face-detection-retail-0005.zip
int4-model.zip
text-recognition-0012.zip
text-spotting-0002-recognizer-decoder.zip
ti_with_large_body.xml.zip
with_gather.xml.zip
with_nd_conv_simple.xml.zip
with_pad_simple.xml.zip
openvino_i4_matmul_model.zip

@lutzroeder lutzroeder assigned lutzroeder and unassigned lutzroeder Nov 22, 2018
lutzroeder pushed a commit that referenced this issue Nov 23, 2018
lutzroeder pushed a commit that referenced this issue Nov 23, 2018
lutzroeder pushed a commit that referenced this issue Nov 23, 2018
lutzroeder added a commit that referenced this issue Nov 23, 2018
Repository owner deleted a comment from demid5111 Nov 24, 2018
Repository owner deleted a comment from demid5111 Nov 24, 2018
Repository owner deleted a comment from demid5111 Nov 24, 2018
Repository owner deleted a comment from demid5111 Nov 24, 2018
lutzroeder added a commit that referenced this issue Nov 24, 2018
Repository owner deleted a comment from demid5111 Nov 24, 2018
Repository owner deleted a comment from demid5111 Nov 24, 2018
Repository owner deleted a comment from demid5111 Nov 24, 2018
@demid5111
Copy link

These are files for testing OpenVINO dot files:

i8_normalized_squeezenet_ssd.dot.zip
i8_normalized_squeezenet11.dot.zip
i8_normalized_vgg16.dot.zip

Repository owner deleted a comment from demid5111 Nov 27, 2018
Repository owner deleted a comment from demid5111 Nov 29, 2018
@lutzroeder
Copy link
Owner Author

@lutzroeder I need your advice. I am now switching to the item !7. How would you recommend to do it taking into consideration that structure of the model (only structure) is in .xml file and weights/biases (only binary data) is in .bin. I would be glad to hear your suggestions in order to not loose time with inappropriate solution from the design perspective.

Have a look at src/caffe2.js which uses a similar approach loading a binary tensor file called init_net.pb. Call context.request to load the file from the same directory as the model file. Make sure to recover if the file failed to load. For decoding, src/mxnet.js might be a good example which has an ndarray decoder for a separate parametersEntry.data byte array. For test, models.json supports comma separated lists for target and source and picks the first entry as the model file.

Repository owner deleted a comment from demid5111 Nov 29, 2018
@lutzroeder
Copy link
Owner Author

@lutzroeder and also the question about coloring (!10). What can I use as a reference? Is it mandatory to define the -metadata.json file?

It is not "mandatory", it could be hardcoded in code. However, in practice you will quickly notice the benefits of having the metadata in a separate file. The format is very similar between all the frameworks and should work for yours as well. For most frameworks the color categories are manually added to -metadata.json but other information like documentation gets updated via scripts.

Repository owner deleted a comment from demid5111 Nov 29, 2018
Repository owner deleted a comment from demid5111 Nov 29, 2018
@lutzroeder
Copy link
Owner Author

@demid5111 any updates on these tasks? In particular will 12. and 13. be done by end of Jan? What's the plan for 5.?

@demid5111
Copy link

demid5111 commented Jan 22, 2019

@lutzroeder can you tell more about the point 5? If it is not very complex, I will do it before points 12 and 13.
I have not yet started working on the re-writing parser. Hopefully, I will start on 29th of January, I will let you know.

@lutzroeder
Copy link
Owner Author

Idea for 5. is to show attributes (Attribute::visible = true) if the value is different from the default value. If the user selects Cmd+D such attributes will show when the graph is rendered. The list should only include few attributes relevant to the user. 12. and 13. should probably be done first. Currently attributes seem to not get parsed correctly (for example, 11 instead of 1,1) so not sure default filtering will work until this is fixed in the parser.

@demid5111
Copy link

@lutzroeder I need to say that your latest commit introduces degradation for the Netron support for the OpenVINO IR v4. I have checked it locally - TensorIterator layer can not be parsed correctly and the whole network can not be rendered at all. Lets revert the commit and I will build upon your version and propose as a pull request till the end of the week. How does that sound for you? Thank you for starting the work with transition to the DOM parser.

@lutzroeder
Copy link
Owner Author

lutzroeder commented Feb 12, 2019

@demid5111 Can you get a PR ready adding the TensorIterator support. It is not used by any test files so adding a test file would be great as well. Along the same lines, is there documentation for the .bin format available and are you working on item 7)?

@demid5111
Copy link

@lutzroeder no problem, I will do that. is it possible not to make the new version/release of the product without TensorIterator being fixed?

@demid5111
Copy link

@lutzroeder yes, I am working on the item 7. however, temporarily switching to the TensorIterator issue

@demid5111
Copy link

@lutzroeder the fix is on the way. I have made a half of work - it is in my fork's master to the moment. I will make a PR in a day or two with the final version. Thank you for waiting for the fix and not upgrading the release version!

@demid5111
Copy link

demid5111 commented Feb 16, 2019

@lutzroeder those are files for testing the fix for the TensorIterator:

@lutzroeder
Copy link
Owner Author

lutzroeder commented Mar 25, 2019

@demid5111 any status updates on 7). See also #307.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants