Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation for protobuf binary encoding #995

Closed
wants to merge 1 commit into from

Conversation

weimingzha0
Copy link

No description provided.

@weimingzha0
Copy link
Author

This is my first PR and my first JS code, so before I implement the full functionality, it's better to make sure it is on the right track. :)

@weimingzha0
Copy link
Author

Hi @lutzroeder will this PR be merged?

@lutzroeder
Copy link
Owner

Ideally there should be a feature using the code for review, to avoid merging code that later isn't tested or used. Model editing is a tricky one, supporting it for one format will likely set expectations that you are working to support and maintain it for many other formats.

@weimingzha0
Copy link
Author

yes, I agree that it might set some expectations to support model editing.
To lower the expectation, we can start from low-level libs like pb encoding or other encoding.
When low-level libs are ready for writing, we can further design how to enable the editing via web UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants