Add product ID, update test #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the info is technically contained in the URL, but I'd rather have a clean payload that gives the customer what it needs rather than do a bunch of string manipulation on receiving the payload.
If you disagree, I'll just use my own fork, otherwise, this works, so I figured I'd just open up the PR.
FYI: wish lists no longer paginate via a "next" link. It's lazy loading (after 23 items, for some reason?), and
cheeriodoesn't support JS execution, so this scraper might be doomed as far as large lists go. I did some googlin' and didn't find anything super useful or I would have incorporated it here. Luckily, my needs are probably suited even if I don't pull the whole wish list.