Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBSan is detecting problems but not failing the CI #697

Closed
squeek502 opened this issue Mar 1, 2024 · 0 comments · Fixed by #698
Closed

UBSan is detecting problems but not failing the CI #697

squeek502 opened this issue Mar 1, 2024 · 0 comments · Fixed by #698

Comments

@squeek502
Copy link
Member

  1. These should be failing the CI
  2. These should be fixed

From the latest master branch CI run:

/home/runner/work/luv/luv/src/thread.c:75:33: runtime error: index 10 out of bounds for type 'luv_val_t[9]'
    #0 0x7fe53a5374bb in luv_thread_arg_set /home/runner/work/luv/luv/src/thread.c:75:33
    #1 0x7fe53a52e11c in luv_new_thread /home/runner/work/luv/luv/src/thread.c:356:18
    #2 0x557044d687cc in precallC /home/runner/work/luv/luv/deps/lua/ldo.c:529:7
    #3 0x557044d66b8e in luaD_precall /home/runner/work/luv/luv/deps/lua/ldo.c:595:7
    #4 0x557044d5a1dd in luaV_execute /home/runner/work/luv/luv/deps/lua/lvm.c:1684:22
    #5 0x557044d0b2dd in ccall /home/runner/work/luv/luv/deps/lua/ldo.c:637:5
    #6 0x557044cb3907 in luaD_callnoyield /home/runner/work/luv/luv/deps/lua/ldo.c:655:3
    #7 0x557044cb5cb4 in f_call /home/runner/work/luv/luv/deps/lua/lapi.c:1038:3
    #8 0x557044c74b91 in luaD_rawrunprotected /home/runner/work/luv/luv/deps/lua/ldo.c:144:3
    #9 0x557044cb5732 in luaD_pcall /home/runner/work/luv/luv/deps/lua/ldo.c:953:12
    #10 0x557044cb4023 in lua_pcallk /home/runner/work/luv/luv/deps/lua/lapi.c:1064:14
    #11 0x557044e0f935 in luaB_xpcall /home/runner/work/luv/luv/deps/lua/lbaselib.c:494:12
    #12 0x557044d687cc in precallC /home/runner/work/luv/luv/deps/lua/ldo.c:529:7
    #13 0x557044d66b8e in luaD_precall /home/runner/work/luv/luv/deps/lua/ldo.c:595:7
    #14 0x557044d5a1dd in luaV_execute /home/runner/work/luv/luv/deps/lua/lvm.c:1684:22
    #15 0x557044d0b2dd in ccall /home/runner/work/luv/luv/deps/lua/ldo.c:637:5
    #16 0x557044cb3907 in luaD_callnoyield /home/runner/work/luv/luv/deps/lua/ldo.c:655:3
    #17 0x557044cb5cb4 in f_call /home/runner/work/luv/luv/deps/lua/lapi.c:1038:3
    #18 0x557044c74b91 in luaD_rawrunprotected /home/runner/work/luv/luv/deps/lua/ldo.c:144:3
    #19 0x557044cb5732 in luaD_pcall /home/runner/work/luv/luv/deps/lua/ldo.c:953:12
    #20 0x557044cb4023 in lua_pcallk /home/runner/work/luv/luv/deps/lua/lapi.c:1064:14
    #21 0x557044c6b61e in docall /home/runner/work/luv/luv/deps/lua/lua.c:160:12
    #22 0x557044c6b33d in handle_script /home/runner/work/luv/luv/deps/lua/lua.c:256:14
    #23 0x557044c68a2d in pmain /home/runner/work/luv/luv/deps/lua/lua.c:645:9
    #24 0x557044d687cc in precallC /home/runner/work/luv/luv/deps/lua/ldo.c:529:7
    #25 0x557044d66b8e in luaD_precall /home/runner/work/luv/luv/deps/lua/ldo.c:595:7
    #26 0x557044d0b1ab in ccall /home/runner/work/luv/luv/deps/lua/ldo.c:635:13
    #27 0x557044cb3907 in luaD_callnoyield /home/runner/work/luv/luv/deps/lua/ldo.c:655:3
    #28 0x557044cb5cb4 in f_call /home/runner/work/luv/luv/deps/lua/lapi.c:1038:3
    #29 0x557044c74b91 in luaD_rawrunprotected /home/runner/work/luv/luv/deps/lua/ldo.c:144:3
    #30 0x557044cb5732 in luaD_pcall /home/runner/work/luv/luv/deps/lua/ldo.c:953:12
    #31 0x557044cb4023 in lua_pcallk /home/runner/work/luv/luv/deps/lua/lapi.c:1064:14
    #32 0x557044c682b2 in main /home/runner/work/luv/luv/deps/lua/lua.c:673:12
    #33 0x7fe53c829d8f  (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: c289da5071a3399de893d2af81d6a30c62646e1e)
    #34 0x7fe53c829e3f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e3f) (BuildId: c289da5071a3399de893d2af81d6a30c62646e1e)
    #35 0x557044baa5e4 in _start (/home/runner/work/luv/luv/build/lua+0x1265e4) (BuildId: bb2b2034300a8f21bd80e98914d1fc7ba3c06734)

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/runner/work/luv/luv/src/thread.c:75:33 in 

/home/runner/work/luv/luv/src/tcp.c:125:16: runtime error: member access within misaligned address 0x7ffcf96c06fc for type 'struct sockaddr_storage', which requires 8 byte alignment
0x7ffcf96c06fc: note: pointer points here
  d0 6e 02 00 02 00 a4 08  7f 00 00 01 00 00 00 00  00 00 00 00 d0 61 00 00  f0 49 00 00 d0 61 00 00
              ^ 
    #0 0x7fe53a53e1ff in parse_sockaddr /home/runner/work/luv/luv/src/tcp.c:125:16
    #1 0x7fe53a540898 in luv_udp_recv_cb /home/runner/work/luv/luv/src/udp.c:376:5
    #2 0x7fe53a625f4b in uv__udp_recvmmsg /home/runner/work/luv/luv/deps/libuv/src/unix/udp.c:195:7
    #3 0x7fe53a622ed2 in uv__udp_recvmsg /home/runner/work/luv/luv/deps/libuv/src/unix/udp.c:238:15
    #4 0x7fe53a61e14a in uv__udp_io /home/runner/work/luv/luv/deps/libuv/src/unix/udp.c:142:5
    #5 0x7fe53a6395a3 in uv__io_poll /home/runner/work/luv/luv/deps/libuv/src/unix/linux.c:1528:11
    #6 0x7fe53a577b5e in uv_run /home/runner/work/luv/luv/deps/libuv/src/unix/core.c:448:5
    #7 0x7fe53a4e9acc in luv_run /home/runner/work/luv/luv/src/loop.c:36:13
    #8 0x557044d687cc in precallC /home/runner/work/luv/luv/deps/lua/ldo.c:529:7
    #9 0x557044d66b8e in luaD_precall /home/runner/work/luv/luv/deps/lua/ldo.c:595:7
    #10 0x557044d5a1dd in luaV_execute /home/runner/work/luv/luv/deps/lua/lvm.c:1684:22
    #11 0x557044d0b2dd in ccall /home/runner/work/luv/luv/deps/lua/ldo.c:637:5
    #12 0x557044cb3907 in luaD_callnoyield /home/runner/work/luv/luv/deps/lua/ldo.c:655:3
    #13 0x557044cb5cb4 in f_call /home/runner/work/luv/luv/deps/lua/lapi.c:1038:3
    #14 0x557044c74b91 in luaD_rawrunprotected /home/runner/work/luv/luv/deps/lua/ldo.c:144:3
    #15 0x557044cb5732 in luaD_pcall /home/runner/work/luv/luv/deps/lua/ldo.c:953:12
    #16 0x557044cb4023 in lua_pcallk /home/runner/work/luv/luv/deps/lua/lapi.c:1064:14
    #17 0x557044e0f935 in luaB_xpcall /home/runner/work/luv/luv/deps/lua/lbaselib.c:494:12
    #18 0x557044d687cc in precallC /home/runner/work/luv/luv/deps/lua/ldo.c:529:7
    #19 0x557044d66b8e in luaD_precall /home/runner/work/luv/luv/deps/lua/ldo.c:595:7
    #20 0x557044d5a1dd in luaV_execute /home/runner/work/luv/luv/deps/lua/lvm.c:1684:22
    #21 0x557044d0b2dd in ccall /home/runner/work/luv/luv/deps/lua/ldo.c:637:5
    #22 0x557044cb3907 in luaD_callnoyield /home/runner/work/luv/luv/deps/lua/ldo.c:655:3
    #23 0x557044cb5cb4 in f_call /home/runner/work/luv/luv/deps/lua/lapi.c:1038:3
    #24 0x557044c74b91 in luaD_rawrunprotected /home/runner/work/luv/luv/deps/lua/ldo.c:144:3
    #25 0x557044cb5732 in luaD_pcall /home/runner/work/luv/luv/deps/lua/ldo.c:953:12
    #26 0x557044cb4023 in lua_pcallk /home/runner/work/luv/luv/deps/lua/lapi.c:1064:14
    #27 0x557044c6b61e in docall /home/runner/work/luv/luv/deps/lua/lua.c:160:12
    #28 0x557044c6b33d in handle_script /home/runner/work/luv/luv/deps/lua/lua.c:256:14
    #29 0x557044c68a2d in pmain /home/runner/work/luv/luv/deps/lua/lua.c:645:9
    #30 0x557044d687cc in precallC /home/runner/work/luv/luv/deps/lua/ldo.c:529:7
    #31 0x557044d66b8e in luaD_precall /home/runner/work/luv/luv/deps/lua/ldo.c:595:7
    #32 0x557044d0b1ab in ccall /home/runner/work/luv/luv/deps/lua/ldo.c:635:13
    #33 0x557044cb3907 in luaD_callnoyield /home/runner/work/luv/luv/deps/lua/ldo.c:655:3
    #34 0x557044cb5cb4 in f_call /home/runner/work/luv/luv/deps/lua/lapi.c:1038:3
    #35 0x557044c74b91 in luaD_rawrunprotected /home/runner/work/luv/luv/deps/lua/ldo.c:144:3
    #36 0x557044cb5732 in luaD_pcall /home/runner/work/luv/luv/deps/lua/ldo.c:953:12
    #37 0x557044cb4023 in lua_pcallk /home/runner/work/luv/luv/deps/lua/lapi.c:1064:14
    #38 0x557044c682b2 in main /home/runner/work/luv/luv/deps/lua/lua.c:673:12
    #39 0x7fe53c829d8f  (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: c289da5071a3399de893d2af81d6a30c62646e1e)
    #40 0x7fe53c829e3f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e3f) (BuildId: c289da5071a3399de893d2af81d6a30c62646e1e)
    #41 0x557044baa5e4 in _start (/home/runner/work/luv/luv/build/lua+0x1265e4) (BuildId: bb2b2034300a8f21bd80e98914d1fc7ba3c06734)

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/runner/work/luv/luv/src/tcp.c:125:16 in 
/home/runner/work/luv/luv/src/tcp.c:125:16: runtime error: load of misaligned address 0x7ffcf96c06fc for type 'sa_family_t' (aka 'unsigned short'), which requires 8 byte alignment
0x7ffcf96c06fc: note: pointer points here
  d0 6e 02 00 02 00 a4 08  7f 00 00 01 00 00 00 00  00 00 00 00 d0 61 00 00  f0 49 00 00 d0 61 00 00
              ^ 
    #0 0x7fe53a53e235 in parse_sockaddr /home/runner/work/luv/luv/src/tcp.c:125:16
    #5 0x7fe53a6395a3 in uv__io_poll /home/runner/work/luv/luv/deps/libuv/src/unix/linux.c:1528:11
    #6 0x7fe53a577b5e in uv_run /home/runner/work/luv/luv/deps/libuv/src/unix/core.c:448:5
    #7 0x7fe53a4e9acc in luv_run /home/runner/work/luv/luv/src/loop.c:36:13
    #8 0x557044d687cc in precallC /home/runner/work/luv/luv/deps/lua/ldo.c:529:7
    #9 0x557044d66b8e in luaD_precall /home/runner/work/luv/luv/deps/lua/ldo.c:595:7
    #10 0x557044d5a1dd in luaV_execute /home/runner/work/luv/luv/deps/lua/lvm.c:1684:22
    #11 0x557044d0b2dd in ccall /home/runner/work/luv/luv/deps/lua/ldo.c:637:5
    #12 0x557044cb3907 in luaD_callnoyield /home/runner/work/luv/luv/deps/lua/ldo.c:655:3
    #13 0x557044cb5cb4 in f_call /home/runner/work/luv/luv/deps/lua/lapi.c:1038:3
    #14 0x557044c74b91 in luaD_rawrunprotected /home/runner/work/luv/luv/deps/lua/ldo.c:144:3
    #15 0x557044cb5732 in luaD_pcall /home/runner/work/luv/luv/deps/lua/ldo.c:953:12
    #16 0x557044cb4023 in lua_pcallk /home/runner/work/luv/luv/deps/lua/lapi.c:1064:14
    #17 0x557044e0f935 in luaB_xpcall /home/runner/work/luv/luv/deps/lua/lbaselib.c:494:12
    #18 0x557044d687cc in precallC /home/runner/work/luv/luv/deps/lua/ldo.c:529:7
    #19 0x557044d66b8e in luaD_precall /home/runner/work/luv/luv/deps/lua/ldo.c:595:7
    #20 0x557044d5a1dd in luaV_execute /home/runner/work/luv/luv/deps/lua/lvm.c:1684:22
    #21 0x557044d0b2dd in ccall /home/runner/work/luv/luv/deps/lua/ldo.c:637:5
    #22 0x557044cb3907 in luaD_callnoyield /home/runner/work/luv/luv/deps/lua/ldo.c:655:3
    #23 0x557044cb5cb4 in f_call /home/runner/work/luv/luv/deps/lua/lapi.c:1038:3
    #24 0x557044c74b91 in luaD_rawrunprotected /home/runner/work/luv/luv/deps/lua/ldo.c:144:3
    #25 0x557044cb5732 in luaD_pcall /home/runner/work/luv/luv/deps/lua/ldo.c:953:12
    #26 0x557044cb4023 in lua_pcallk /home/runner/work/luv/luv/deps/lua/lapi.c:1064:14
    #27 0x557044c6b61e in docall /home/runner/work/luv/luv/deps/lua/lua.c:160:12
    #28 0x557044c6b33d in handle_script /home/runner/work/luv/luv/deps/lua/lua.c:256:14
    #29 0x557044c68a2d in pmain /home/runner/work/luv/luv/deps/lua/lua.c:645:9
    #30 0x557044d687cc in precallC /home/runner/work/luv/luv/deps/lua/ldo.c:529:7
    #31 0x557044d66b8e in luaD_precall /home/runner/work/luv/luv/deps/lua/ldo.c:595:7
    #32 0x557044d0b1ab in ccall /home/runner/work/luv/luv/deps/lua/ldo.c:635:13
    #33 0x557044cb3907 in luaD_callnoyield /home/runner/work/luv/luv/deps/lua/ldo.c:655:3
    #34 0x557044cb5cb4 in f_call /home/runner/work/luv/luv/deps/lua/lapi.c:1038:3
    #35 0x557044c74b91 in luaD_rawrunprotected /home/runner/work/luv/luv/deps/lua/ldo.c:144:3
    #36 0x557044cb5732 in luaD_pcall /home/runner/work/luv/luv/deps/lua/ldo.c:953:12
    #37 0x557044cb4023 in lua_pcallk /home/runner/work/luv/luv/deps/lua/lapi.c:1064:14
    #38 0x557044c682b2 in main /home/runner/work/luv/luv/deps/lua/lua.c:673:12
    #39 0x7fe53c829d8f  (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: c289da5071a3399de893d2af81d6a30c62646e1e)
    #40 0x7fe53c829e3f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e3f) (BuildId: c289da5071a3399de893d2af81d6a30c62646e1e)
    #41 0x557044baa5e4 in _start (/home/runner/work/luv/luv/build/lua+0x1265e4) (BuildId: bb2b2034300a8f21bd80e98914d1fc7ba3c06734)

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/runner/work/luv/luv/src/tcp.c:135:51 in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass -fno-sanitize-recover=all to make all UBSan detections fatal squeek502/luv
1 participant
@squeek502