Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-fs-stat.lua. Fix to support fs.open(path, flags, nil, callback) #301

Merged
merged 4 commits into from Aug 15, 2012

Conversation

hnakamur
Copy link
Member

When mode is explicitly passed as nil, an error occurred in fs.open()
It is fixed now.

@travisbot
Copy link

This pull request fails (merged b1842d2 into 6380368).

you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http:--www.apache.org/licenses/LICENSE-2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the slashes are messed up here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a good catch!
I fixed them in commit 7fb77bf

@hnakamur hnakamur closed this Aug 15, 2012
@hnakamur hnakamur reopened this Aug 15, 2012
@travisbot
Copy link

This pull request passes (merged 691748d into 6380368).

rphillips added a commit that referenced this pull request Aug 15, 2012
Add test-fs-stat.lua. Fix to support fs.open(path, flags, nil, callback)
@rphillips rphillips merged commit f967fe2 into luvit:master Aug 15, 2012
zhaozg pushed a commit to zhaozg/luvit that referenced this pull request Apr 2, 2019
Add test-fs-stat.lua. Fix to support fs.open(path, flags, nil, callback)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants