Fixed Calculation of MinMax

LuxDataframe now correctly gets the yMinMax for quantitative variables when connected to a database
lux-org · Jun 1, 2020 · 5be1b9b · 5be1b9b
1 parent 623582f
commit 5be1b9b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lux/luxDataFrame/LuxDataframe.py b/lux/luxDataFrame/LuxDataframe.py
@@ -172,7 +172,7 @@ def computeStats(self):
             self.cardinality[dimension] = len(self.uniqueValues[dimension])
             if self.dtypes[dimension] == "float64" or self.dtypes[dimension] == "int64":
                 self.xMinMax[dimension] = (min(self.uniqueValues[dimension]), max(self.uniqueValues[dimension]))
-                self.yMinMax[dimension] = (self[dimension].min(), self[dimension].max())
+                self.yMinMax[dimension] = (min(self.uniqueValues[dimension]), max(self.uniqueValues[dimension]))
                     # print(self.xMinMax[dimension])
 
     #######################################################
@@ -189,6 +189,7 @@ def setSQLConnection(self, connection, t_name):
         if self.toggleBenchmarking == True:
             toc = time.perf_counter()
             print(f"Extracted Metadata from SQL Database in {toc - tic:0.4f} seconds")
+        self.setExecutorType("SQL")
 
     def computeSQLDatasetMetadata(self):
         self.getSQLAttributes()
@@ -215,7 +216,7 @@ def computeSQLStats(self):
         for dimension in self.columns:
             if self.dataTypeLookup[dimension] == 'quantitative':
                 self.xMinMax[dimension] = (min(self.uniqueValues[dimension]), max(self.uniqueValues[dimension]))
-                self.yMinMax[dimension] = (self[dimension].min(), self[dimension].max())
+                self.yMinMax[dimension] = (min(self.uniqueValues[dimension]), max(self.uniqueValues[dimension]))
 
     def getSQLAttributes(self):
         if "." in self.table_name: