-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VisList properties overidden upon refresh_source
initialization
#68
Comments
Now supporting a custom title override by avoiding unnecessary calls to enumerate_collection. Mark and channel override non-trivial since we need to extend |
* add intent with getters and setters * make min_max private property * make mark private property (#68) * added tests for setting intent for Vis and VisList
Currently, we don't support mark override on Vis, since there can be conflicts with the input intent (e.g. user intent involves only a single quantitative attribute, but sets mark as scatterplot). We can revisit this once there are a better validator and parser that catches these issues. For now, |
When properties are specified in the Vis and fed inside the VisList, the refresh_source goes through the parser, validator and compiler. At the compiler stage, the Vis properties gets overridden by the automatically determined values. We should tolerate specified
title
,mark
and other Vis properties to override the automatically determined values.This is an example test that evaluates this, the last two line fails because the
title
andmark
takes on the new values.This example should be added to the test suite once we resolve this issue.
The text was updated successfully, but these errors were encountered: