Updating SQL Executor Test Suite #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses unique value metadata to verify if a value is valid
frame.py was trying to import luxWidget instead of luxwidget
… with SQL Executor Some interestingness functions required the number of observations in the data and visualization, so I added these values to the metadata to make the scoring work when using the SQL executor Added tests for SQL executor
Removed lines that changed Year column type to datetime
SQL Executor tests interfering with travis build, commenting out for now
…nto Database-Executor
…arts * update number of bars calculation to account for when len(data) double counts
Issue where validator was relying on metadata which was not yet generated, moved metadata calculation before validation step in frame.py
Renamed num_obs to length, removed ordinal variable from Executor mapping function
* added functionality to delete Vis * fixed deletion logic * add observer to automatically update deletions * able to refresh widget on setting intent * support for setting intent from frontend * quick fix to output * changed variable intentindex name
* remove and register action functions * update changes inframe.py * update changes inframe.py * add documentation and changes * indentation and comments * new line * globally defined default display works with warning * no examples * add back space * new line * uncomment docstring Co-authored-by: Caitlyn Chen <caitlynachen@berkeley.edu>
Updated travis.yml file to create postgresql database in test instance. Added script to populate test database with data.
Updated database credentials
Added tests for basic SQL Executor functionality.
* added functionality to delete Vis * fixed deletion logic * add observer to automatically update deletions * able to refresh widget on setting intent * support for setting intent from frontend * quick fix to output * changed variable intentindex name * added better error msg for > 1 intent for vis * reverting some changes * Updated readme * updated readthedoc documentation * added config to default display documentation * Update README.md Co-authored-by: Doris Lee <dorisjunglinlee@gmail.com>
…x-org#174) * update export tutorial to add explanation for standalone argument * minor fixes and remove cell output in notebooks * added contributing doc * fix bugs and uncomment some tests * remove raise warning * remove unnecessary import * split up rename test into two parts * fix setting warning, fix data_type bugs and add relevant tests * remove ordinal data type * add test for small dataframe resetting index * add loc and iloc tests * fix attribute access directly to dataframe * add small changes to code * added test for qcut and cut * add check if dtype is Interval * added qcut test * fix Record KeyError * add tests * take care of reset_index case * small edits * add data_model to column_group Clause * small edits for row_group * fixes to row group Co-authored-by: Doris Lee <dorisjunglinlee@gmail.com>
*remove jupyter lab url
fix slack link
Issue caused when user sets an index. The Pandas Executor was not correctly renaming this new index column to Record in execute_aggregate()
…-org#180) * improve datetime warning message with starter templates * Handling NaN value errors * skipping validator check for NaN filter values * adding special case for PandasExecutor to map filter NaN to isna() * fixing unevenness metric when bar values are NaN * eliminate 1-cardinality filters in Filter action (since equal to overall) * fixed deviation array unequal bug when NaN * Handling NaN filter and data type * fixed data type detection when int coerced to float when containing NaN * added test for applying NaN filter * Ensure that LuxSeries displayed when there is NaN * ensure that NaNs are not dropped in groupbys * exclude NaN values in deviation calculation * fix unnamed series issue * improved debugging message for LuxSeries * Override pd.Series with LuxSeries * Fixes for type checking and line charts with NaNs * exclude NaN for line charts to prevent large axes offsetting * improved type checking for float no-longer NaN columns * fixed and improved deviation calculation test * added float categorical test
Readded missing dropna parameter within execute_aggregate() groupby function call
Removed duplicate set_SQL_connection function from config. Updated tests to reflect these changes. Merged in recent changes in master branch.
Updated to include numpy version requirement
Updated documentation in SQLExecutor.py. Updated example notebook for SQLExecutor
Updated example notebook for the SQL Executor and the script to upload the example dataset to a local Postgres database.
Adjusted tests to reference correct PostgreSQL table
Updated the travis.yml and sql executor test scripts to refer to the correct postgres database
Codecov Report
@@ Coverage Diff @@
## sql-engine #196 +/- ##
==============================================
- Coverage 82.29% 81.28% -1.01%
==============================================
Files 39 39
Lines 2632 2923 +291
==============================================
+ Hits 2166 2376 +210
- Misses 466 547 +81
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.