Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullable dtypes not compatible with Altair #250

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Fix nullable dtypes not compatible with Altair #250

merged 3 commits into from
Feb 3, 2021

Conversation

westernguy2
Copy link
Contributor

This fixes the issue in #247. It checks if the dtype is any float value, including Float64Dtype and converts it to the numpy float, which is compatible with Altair.

@dorisjlee dorisjlee linked an issue Feb 3, 2021 that may be closed by this pull request
df.convert_dtypes() raising new error in Pandas 1.2.0 #247
Closed
@dorisjlee
Copy link
Member

Thanks @westernguy2 ! This is now working with Pandas 1.2.1.

@dorisjlee dorisjlee closed this Feb 3, 2021
@dorisjlee dorisjlee reopened this Feb 3, 2021
@dorisjlee dorisjlee merged commit 2ea95d8 into lux-org:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

df.convert_dtypes() raising new error in Pandas 1.2.0
2 participants
@westernguy2 @dorisjlee