Bug Fixes in Histogram Binning #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLExecutor binning function was breaking if there was any Null value in the data it was trying to query. Adjusted querying to always filter out Null values from the data.
Fixed issue where width_bucket query was not working with variables of integer type. Resolved by casting the variable to float. Fixed issue in creating bucket edges for histograms. Resolved by using min_max parameter of the dataframe rather than the min and max of a variable's unique values.
Updated Tests to follow changes to SQLExecutor filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added filtering out of null values in all SQL queries
Fixed issue where binning would fail with integer type variables