Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_vis.py #315

Merged
merged 1 commit into from
Mar 20, 2021
Merged

Update test_vis.py #315

merged 1 commit into from
Mar 20, 2021

Conversation

thyneb19
Copy link
Contributor

Overview

Issue when running test_vis in Github Actions. Adjusted test_scatter_chart and test_colored_scatter_chart

Changes

The matplotlib cases were failing on the Github Actions test suite. Adjusted assert statements to also check for axis font size.

Issue when running test_vis in Github Actions. Adjusted test_scatter_chart and test_colored_scatter_chart
@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #315 (48f8b00) into master (0748949) will decrease coverage by 0.17%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   81.06%   80.88%   -0.18%     
==========================================
  Files          50       50              
  Lines        3596     3615      +19     
==========================================
+ Hits         2915     2924       +9     
- Misses        681      691      +10     
Impacted Files Coverage Δ
lux/vislib/matplotlib/ScatterChart.py 75.29% <75.00%> (-5.01%) ⬇️
lux/vislib/altair/Heatmap.py 93.10% <0.00%> (-3.45%) ⬇️
lux/vislib/matplotlib/Heatmap.py 96.66% <0.00%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182a4b7...48f8b00. Read the comment docs.

@dorisjlee dorisjlee merged commit 127806f into lux-org:master Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants