Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT-#493: Extensible. #494

Merged
merged 4 commits into from
Jul 4, 2023
Merged

FEAT-#493: Extensible. #494

merged 4 commits into from
Jul 4, 2023

Conversation

rentruewang
Copy link
Contributor

After this refactor, Making Vis etc support the pandas library is as easy as defining 4 1-liner classes.

Overview

For example, for modin defining this one-liner class is enough for it to be used with Vis:

class LuxModinDF(LuxDataFrameMixin, modin.DataFrame): pass

then wrap the dataframe df by:

df = LuxModinDF(df)

Changes

I refactored Lux's pandas subclasses into mixins and thin wrappers using mixins (much like the above one liner).

Example Output

No change.

After this refactor, Making `Vis` etc support the pandas library is as easy as defining 4 1-liner classes.
@dorisjlee
Copy link
Member

@rentruewang can you run the linter to prevent test fail?

@rentruewang
Copy link
Contributor Author

rentruewang commented Jun 20, 2023

@dorisjlee Do you know what linter I should run? I was able to pass pre-commit, and I didn't make changes to those that failed black --check. Would you like me to run black on those files?

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 98.70% and project coverage change: -0.18 ⚠️

Comparison is base (05fd0fe) 72.76% compared to head (637ef0c) 72.59%.

❗ Current head 637ef0c differs from pull request most recent head 91a0799. Consider uploading reports for the commit 91a0799 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
- Coverage   72.76%   72.59%   -0.18%     
==========================================
  Files          56       56              
  Lines        4619     4619              
==========================================
- Hits         3361     3353       -8     
- Misses       1258     1266       +8     
Impacted Files Coverage Δ
lux/core/series.py 57.52% <95.00%> (+0.76%) ⬆️
lux/core/frame.py 80.83% <100.00%> (+0.04%) ⬆️
lux/core/groupby.py 100.00% <100.00%> (ø)
lux/executor/PandasExecutor.py 93.96% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dorisjlee dorisjlee merged commit 972e5ec into lux-org:master Jul 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants