Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option not to override s and S #53

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

madand
Copy link
Contributor

@madand madand commented Jun 15, 2016

At first, I would like to thank you for the useful package. Good work! 👍

This PR adds a new boolean option evil-cleverparens-use-s-and-S to prevent shadowing of s and S.

Current code can only detect evil-snipe's use of s and S, with implications on the packages load order. Since I use Avy on s and S, after activation of the evil-cleverparens I ended up without my bindings on these keys. My current workaround is:

(with-eval-after-load 'evil-cleverparens
  (evil-define-key 'normal evil-cleverparens-mode-map
    ;; I use s and S for Avy.
    "s" nil
    "S" nil))

But I feel that having a separate flag for this is a cleaner way to address the issue.

@luxbock
Copy link
Collaborator

luxbock commented Jul 18, 2017

Sure seems sensible.

@luxbock luxbock merged commit 9bce7cc into emacs-evil:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants