Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_flag() doesn't add flags to any C++ files in project #68

Open
diablodale opened this issue May 30, 2023 · 1 comment
Open

add_flag() doesn't add flags to any C++ files in project #68

diablodale opened this issue May 30, 2023 · 1 comment

Comments

@diablodale
Copy link
Contributor

add_flag() in this project's cmake doesn't add flags to C++ files.
I suspect when c++ files were added to the project, the dev didn't update cmake to support them.

Trivial fix now in my fork. Will link to this issue below. Easy cherry pick.

diablodale added a commit to diablodale/XLink that referenced this issue May 30, 2023
@diablodale
Copy link
Contributor Author

commit above.

  • cmake changes including bumping up one dot release of cmake to 3.3 due to existing code already uses 3.3 features like $<COMPILE_LANGUAGE
  • one source file must be updated due to correctly applied flags. More signed/unsigned mismatches. There are more....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant