-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gen2: add MonoCamera and StereoDepth nodes #23
Conversation
build in example/build, run: ./myapp mono
(the branch was rebased)
Run: ./myapp depth Device FW not yet updated, TODO
XLinkIn nodes to link to
for already rectified input images. Update device FW, StereoDepth working with images received from host
- basic argument parsing - "d" / "debug" option to run with debugger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from checks failing.
For style, run the clangformat
target to modify style according to clang format style file (warning, it modifies in place, make sure to commit before, in case something goes wrong)
cmake --build [path/to/build/dir] --target clangformat
Input left{*this, "left", Input::Type::SReceiver, {{DatatypeEnum::Buffer, true}}}; | ||
Input right{*this, "right", Input::Type::SReceiver, {{DatatypeEnum::Buffer, true}}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed now in gen2_imagemanip. Check method canConnect
. Preferably set back to ImgFrame and apply the fix from gen2_imagemanip to canConnect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks!
…LinkIn nodes to link to" -- will apply next a proper fix taken from gen2_imagemanip This reverts commit a232078.
-- will allow XLinkIn to link to nodes with ImgFrame inputs
Merged to |
Reopening to change target branch, to get marked as "merged". |
Related PR: luxonis/depthai-shared#10