Gen2: add MonoCamera and StereoDepth nodes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build in example/build, run: ./myapp mono
(the branch was rebased)
Run: ./myapp depth Device FW not yet updated, TODO
XLinkIn nodes to link to
for already rectified input images. Update device FW, StereoDepth working with images received from host
- basic argument parsing - "d" / "debug" option to run with debugger
Luxonis-Brandon
added
enhancement
themarpe
requested changes
Nov 23, 2020
There was a problem hiding this comment.
LGTM apart from checks failing.
For style, run the clangformat target to modify style according to clang format style file (warning, it modifies in place, make sure to commit before, in case something goes wrong)
cmake --build [path/to/build/dir] --target clangformat
themarpe
requested changes
Nov 29, 2020
Comment on lines
23
to
24
| Input left{*this, "left", Input::Type::SReceiver, {{DatatypeEnum::Buffer, true}}}; | ||
| Input right{*this, "right", Input::Type::SReceiver, {{DatatypeEnum::Buffer, true}}}; |
There was a problem hiding this comment.
This is fixed now in gen2_imagemanip. Check method canConnect. Preferably set back to ImgFrame and apply the fix from gen2_imagemanip to canConnect
…LinkIn nodes to link to" -- will apply next a proper fix taken from gen2_imagemanip This reverts commit a232078.
-- will allow XLinkIn to link to nodes with ImgFrame inputs
|
Merged to |
|
Reopening to change target branch, to get marked as "merged". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: luxonis/depthai-shared#10