Unreachable code in dai::DataOutputQueue::get() -- unclear intention

[diablodale]

Unreachable code in dai::DataOutputQueue::get() -- the intention is unclear. Needs a review.
On line 175-6, do you want to throw, or return nullptr. Can't do both.

depthai-core/include/depthai/device/DataQueue.hpp

Lines 171 to 179 in efa3deb

	std::shared_ptr<T> get() {
	if(!running) throw std::runtime_error(exceptionMessage.c_str());
	std::shared_ptr<ADatatype> val = nullptr;
	if(!queue.waitAndPop(val)) {
	throw std::runtime_error(exceptionMessage.c_str());
	return nullptr;
	}
	return std::dynamic_pointer_cast<T>(val);
	}

Setup

• all OS
• all compilers
• depthai-core v2.13.2

Repro

MSVC compiler told me it is unreachable.
Verified by code review. It is unreachable.

Result

The code will throw. But it is unclear if that is the dev's intention.

Expected

Code matches dev's intention.

[themarpe]

return nullptr is redundant in this case - the underlying queue was destructed in this case.
If the underlying queue was destructed, then the caller is given the reason why and gets out of the blocked call.

[diablodale]

verified it is merged into develop codebase