You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The desired MSVC conformant preprocessor flags like /Zc:preprocessor are not applied on compile of depthai-core conformant tests.
From what I understand, it is because INTERFACE is used below. It should be PRIVATE or PUBLIC instead. I recommend PRIVATE.
cmake config and build for x64, shared, Debug with all tests and examples to be built
Result
After the config, inspect the makefiles or ninja.build or compile_commands.json.
The /Zc:preprocessor and /experimental:preprocessor do not appear on the cl.exe options for conformant tests
Expected
The /Zc:preprocessor and /experimental:preprocessor appear on the cl.exe options for conformant tests
The text was updated successfully, but these errors were encountered:
diablodale
added a commit
to diablodale/depthai-core
that referenced
this issue
Feb 27, 2022
The desired MSVC conformant preprocessor flags like
/Zc:preprocessor
are not applied on compile of depthai-core conformant tests.From what I understand, it is because
INTERFACE
is used below. It should bePRIVATE
orPUBLIC
instead. I recommend PRIVATE.depthai-core/tests/CMakeLists.txt
Lines 44 to 46 in 5cafb68
Setup
Repro
Result
After the config, inspect the makefiles or ninja.build or compile_commands.json.
The
/Zc:preprocessor
and/experimental:preprocessor
do not appear on the cl.exe options for conformant testsExpected
The
/Zc:preprocessor
and/experimental:preprocessor
appear on the cl.exe options for conformant testsThe text was updated successfully, but these errors were encountered: