add (demo, test) added demo code and the test #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SzabolcsGergely
approved these changes
Feb 25, 2021
themarpe
requested changes
Feb 25, 2021
| detectionNetwork->setNumClasses(80); | ||
| detectionNetwork->setCoordinateSize(4); | ||
| std::vector<float> anchors{10, 14, 23, 27, 37, 58, 81, 82, 135, 169, 344, 319}; | ||
| detectionNetwork->setAnchors(anchors); |
There was a problem hiding this comment.
Use initializer lists for clearer usage
// network specific!!
detectionNetwork->setConfidenceThreshold(0.5f);
detectionNetwork->setNumClasses(80);
detectionNetwork->setCoordinateSize(4);
detectionNetwork->setAnchors({10, 14, 23, 27, 37, 58, 81, 82, 135, 169, 344, 319});
detectionNetwork->setAnchorMasks({{"side13", {1,2,3}}, {"side26", {3,4,5}}});
detectionNetwork->setIouThreshold(0.5f);
|
|
||
| counter++; | ||
| auto current_time = std::chrono::steady_clock::now(); | ||
| float elapsed_s = std::chrono::duration_cast<std::chrono::milliseconds>(current_time-start_time).count() / 1000.; |
There was a problem hiding this comment.
Replace with:
auto elapsed = duration_cast<duration<float>>(current_time - start_time);
if (elapsed > seconds(1)){
fps = counter / elapsed;
....
There was a problem hiding this comment.
The above creates a representation of seconds in float format. So below division will work as expected.
Otherwise, counter could be float and then no duration cast would be needed
| } | ||
|
|
||
| int main(int argc, char** argv) { | ||
| using namespace std; |
There was a problem hiding this comment.
Add:
using namespace std::chrono;
| } | ||
| cv::putText(frame, label_str, cv::Point(x1 + 10, y1 + 20), cv::FONT_HERSHEY_TRIPLEX, 0.5, color); | ||
| char conf_str[10]; | ||
| snprintf(conf_str, sizeof conf_str, "%.2f", d.confidence*100); |
There was a problem hiding this comment.
Preferably C++ish
std::stringstream s;
s << std::fixed << std::setprecision(2) << d.confidence*100;
// s.str();
| cv::rectangle(frame, cv::Rect(cv::Point(x1, y1), cv::Point(x2, y2)), color, cv::FONT_HERSHEY_SIMPLEX); | ||
| } | ||
|
|
||
| char fps_str[15]; |
themarpe
approved these changes
Mar 1, 2021
| label_str = label_map[label_index]; | ||
| int labelIndex = d.label; | ||
| std::string labelStr = to_string(labelIndex); | ||
| if(labelIndex < sizeof(label_map) / sizeof(label_map[0])) { |
There was a problem hiding this comment.
Rather do:
static const auto labelMap = { ... } // or static const std::vector<std::string> = { ... }
...
if(labelIndex < labelMap.size()) {
...
}
| label_str = label_map[label_index]; | ||
| int labelIndex = d.label; | ||
| std::string labelStr = to_string(labelIndex); | ||
| if(labelIndex < sizeof(label_map) / sizeof(label_map[0])) { |
Erol444
force-pushed
the
gen2_yolov4_tiny_demo
branch
from
8b6ea69
to
6988743
Compare
SzabolcsGergely
added a commit
that referenced
this pull request
Mar 4, 2021
SzabolcsGergely
added a commit
that referenced
this pull request
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added cpp example and test