Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build from sources error #514

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Fix build from sources error #514

merged 1 commit into from
Jul 6, 2022

Conversation

themarpe
Copy link
Collaborator

@themarpe themarpe commented Jul 6, 2022

  • Properly logs when building from Source Code (no submodules) downloaded package from GitHub
  • Fixes when proper core (with submodules) package is extracted and used under an existing parent git repo

Both are improvements for initial Getting Started UX

@themarpe
Copy link
Collaborator Author

themarpe commented Jul 6, 2022

A possible TODO is adding a CI check for these cases:

  • Using the proper package, extract & build (should succeed)
  • Using the proper package under an existing parent git repo, extract & build (should succeed)
  • Using "Source Code" package, extract & build (should fail, with specific error message)
  • Cloning without submodules initialized, extract & build (should fail, with specific error message)

@themarpe themarpe merged commit a6e7319 into develop Jul 6, 2022
@themarpe themarpe deleted the build_from_sources_error branch July 6, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build error. how to think about this problem error ==> if(${status} STREQUAL "-")
2 participants