-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrated the triangulation-3D-visualizer
to gen2.
#110
Conversation
…to crop the image
luxonis/depthai#216 <- Ticket |
Sweet. This will be great for many to have. And I love that it uses the script node as that affords the capability for folks to customize it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the old triangulation-3D-visualizer
(and leave readme note that it was moved to gen2, like here).
This way, we should have less and less codebase written in Gen1, so we won't have to maintain it and will direct users to use Gen2 by default
You may have already done this, but please make sure there is a redirect in place so the old link still works. As we want to allow folks to link to any of our examples, experiments, anything with confidence that their customers or fans (say if it's a Youtube channel) doesn't end up with a link that goes nowhere. |
Great demo - thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Used Script node to crop the image