Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated the triangulation-3D-visualizer to gen2. #110

Merged
merged 6 commits into from
Apr 27, 2021

Conversation

Erol444
Copy link
Member

@Erol444 Erol444 commented Apr 19, 2021

Used Script node to crop the image

@Erol444 Erol444 requested a review from VanDavv April 19, 2021 16:47
@Erol444
Copy link
Member Author

Erol444 commented Apr 19, 2021

luxonis/depthai#216 <- Ticket

@Luxonis-Brandon
Copy link
Contributor

Sweet. This will be great for many to have. And I love that it uses the script node as that affords the capability for folks to customize it!

Copy link
Contributor

@VanDavv VanDavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the old triangulation-3D-visualizer (and leave readme note that it was moved to gen2, like here).

This way, we should have less and less codebase written in Gen1, so we won't have to maintain it and will direct users to use Gen2 by default

gen2-triangulation/README.md Outdated Show resolved Hide resolved
@Luxonis-Brandon
Copy link
Contributor

removed gen1 triangulation experiment

You may have already done this, but please make sure there is a redirect in place so the old link still works. As we want to allow folks to link to any of our examples, experiments, anything with confidence that their customers or fans (say if it's a Youtube channel) doesn't end up with a link that goes nowhere.

@Erol444
Copy link
Member Author

Erol444 commented Apr 26, 2021

Added the video
giff

@Erol444 Erol444 requested a review from VanDavv April 26, 2021 20:58
@Luxonis-Brandon
Copy link
Contributor

Great demo - thanks!

Copy link
Contributor

@VanDavv VanDavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Erol444 Erol444 merged commit c2ac985 into master Apr 27, 2021
@Erol444 Erol444 deleted the gen2-triangulation-demo branch April 27, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants