Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for enabling replay looping #1017

Merged
merged 6 commits into from
May 11, 2023
Merged

Add option for enabling replay looping #1017

merged 6 commits into from
May 11, 2023

Conversation

daniilpastukhov
Copy link
Contributor

  • API: Replay.set_loop(True/False)
  • Works for video only as of now.

@Erol444
Copy link
Member

Erol444 commented May 11, 2023

@daniilpastukhov maybe we change API to just oak.replay.loop(True)?

@daniilpastukhov daniilpastukhov changed the title Add option for enable replay looping Add option for enabling replay looping May 11, 2023
@daniilpastukhov
Copy link
Contributor Author

I think it's more intuitive to have a verb there (like set) that indicates what this method does

@daniilpastukhov daniilpastukhov merged commit 7178c14 into develop May 11, 2023
@daniilpastukhov daniilpastukhov deleted the feat/replay_loop branch May 11, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erol444 Erol444 Erol444 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniilpastukhov @Erol444