Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse existing components #1071

Merged
merged 4 commits into from
Jul 2, 2023
Merged

Reuse existing components #1071

merged 4 commits into from
Jul 2, 2023

Conversation

geektrove
Copy link
Contributor

  • Reuse existing components in stereo creation
  • Return existing CameraComponent when same socket is specified
  • Pick first color sensor when source is color or rgb (OAK-D-SR support)
  • Rename create_camera with just camera (same for stereo and all_cameras)

@geektrove geektrove self-assigned this Jul 2, 2023
@daniilpastukhov daniilpastukhov merged commit 0aa1668 into develop Jul 2, 2023
18 of 29 checks passed
@daniilpastukhov daniilpastukhov deleted the feature/reuse_components branch July 2, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniilpastukhov daniilpastukhov daniilpastukhov approved these changes

Assignees

@geektrove geektrove

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geektrove @daniilpastukhov