Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated versions of sphinx requirements #1097

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Updated versions of sphinx requirements #1097

merged 5 commits into from
Aug 10, 2023

Conversation

Erol444
Copy link
Member

@Erol444 Erol444 commented Aug 10, 2023

Before:

image

After:

image

@Erol444 Erol444 requested a review from jakaskerl August 10, 2023 16:01
@jakaskerl
Copy link
Contributor

Looks good except github links.
Is:
https://github.com/luxonis/depthai/depthai_sdk/examples/NNComponent/face_detection_color.py
Should be:
https://github.com/luxonis/depthai/blob/main/depthai_sdk/examples/NNComponent/face_detection_color.py

jakaskerl
jakaskerl approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@jakaskerl jakaskerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Erol444 Erol444 merged commit c6f1263 into main Aug 10, 2023
4 checks passed
@Erol444 Erol444 deleted the update_docs_requirements branch August 10, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakaskerl jakaskerl jakaskerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Erol444 @jakaskerl