Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rosbag/db3 recording #856

Merged
merged 13 commits into from
Feb 15, 2023
Merged

rosbag/db3 recording #856

merged 13 commits into from
Feb 15, 2023

Conversation

Erol444
Copy link
Member

@Erol444 Erol444 commented Nov 25, 2022 •
edited

Started working on SDK ROS streaming

recorded .bag opened in foxglove studio:
image

@Erol444 Erol444 changed the base branch from main to develop November 25, 2022 16:58
@Erol444 Erol444 marked this pull request as ready for review January 27, 2023 19:58
@Erol444 Erol444 changed the title Ros stream rosbag/db3 recording Jan 27, 2023
@Erol444 Erol444 mentioned this pull request Jan 31, 2023
Open
daniilpastukhov
daniilpastukhov approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@daniilpastukhov daniilpastukhov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is a bunch of commented code. I think it'd be good to cleanup parts that we won't need in the future

@Erol444
Copy link
Member Author

Erol444 commented Feb 15, 2023

Plan is to also add ros1 support in the future, that's why I left it there (commented out). For now it just throws "not yet supported" error.

@Erol444 Erol444 merged commit f1ed02b into develop Feb 15, 2023
@Erol444 Erol444 deleted the ros_stream branch February 15, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniilpastukhov daniilpastukhov daniilpastukhov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Erol444 @daniilpastukhov