Refactored how pipeline is being built #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Erol444
commented
Mar 13, 2023
•
Erol444
commented
- Refactored component creation, so we have device/pipeline on component creation already
- ^ allows getting available camera sensors on device and their resolutions. Now SDK supports OAK-D-LR / OAK-D-SR
- Added oak.create_all_cameras() function, creates List[CameraComponent] for each camera sensor on the OAK cam, example code below
- Added support so NNComponent accepts node output as an input
Erol444
changed the title
… configs directly from the device. Requires latest develop from depthai-python
| for res in cameraSensor(sensorName).resolutions: | ||
| size = cameraResolutions[res] | ||
|
|
||
| resolutions = [get_sensor_resolution(type, conf.width, conf.height) for conf in sensor.configs if conf.type == type] |
There was a problem hiding this comment.
dai.CameraFeatures doesn't seem to have configs attribute (depthai==2.20.2), therefore preview_all_cameras.py doesn't work for me cc @Erol444
There was a problem hiding this comment.
@daniilpastukhov yep, I added it not long ago, you'd need to use depthai==2.20.2.0.dev+6f79483e1e58a441c942101092681466ae8961fb (it's also in requirements)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.