-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored how pipeline is being built #970
Conversation
Erol444
commented
Mar 13, 2023
•
edited
Loading
edited
- Refactored component creation, so we have device/pipeline on component creation already
- ^ allows getting available camera sensors on device and their resolutions. Now SDK supports OAK-D-LR / OAK-D-SR
- Added oak.create_all_cameras() function, creates List[CameraComponent] for each camera sensor on the OAK cam, example code below
- Added support so NNComponent accepts node output as an input
… configs directly from the device. Requires latest develop from depthai-python
for res in cameraSensor(sensorName).resolutions: | ||
size = cameraResolutions[res] | ||
|
||
resolutions = [get_sensor_resolution(type, conf.width, conf.height) for conf in sensor.configs if conf.type == type] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dai.CameraFeatures
doesn't seem to have configs
attribute (depthai==2.20.2), therefore preview_all_cameras.py
doesn't work for me cc @Erol444
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniilpastukhov yep, I added it not long ago, you'd need to use depthai==2.20.2.0.dev+6f79483e1e58a441c942101092681466ae8961fb
(it's also in requirements)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM