-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out network support #995
Out network support #995
Conversation
LGTM, thanks @Erol444! @PetrNovota do you mind testing this and checking if it will work for you? (This is not yet merged in rvc3_support/develop branches, so you can test on any RVC2 device). If all looks good, I'll merge it into |
@moratom thank you for adding this feature so fast. I tested you example and:
|
… can use that message.
@PetrNovota fixed, this now works:
|
@@ -176,7 +177,7 @@ def setup(self, pipeline: dai.Pipeline, device: dai.Device, _) -> List[XoutBase] | |||
xoutbase.setup_base(self.new_packet) | |||
xouts.append(xoutbase) | |||
|
|||
if self.visualizer: | |||
xoutbase.setup_visualize(self.visualizer, xoutbase.name) | |||
if hasattr(xoutbase, 'setup_visualize'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniilpastukhov - I'm not exactly sure, but why do we have visualizers inside the oak.sync()
?
@PetrNovota does everything work as expected? Can we merge the PR? |
LGTM |
@Erol444 which depthai version should I used with this new sdk? Currently, I am using
and when I delete the line then I get another error
|
@PetrNovota I think the minimum version is 2.21 (or equivalent to it) |
@daniilpastukhov oh I get it i cannot test it on rvc3. my bad |
Setup:
Packets have attribute
When I delete the import, I can run the code but it looks like the Packets ImageFrame attribute has wrong name There seems to be an performance issue. If I run the above example without the visualizer and without the nn_data output, then it runns at 20FPS. When I add the nn_data to the callback, the FPS drops to 5FPS |
cc: @Erol444 and @daniilpastukhov ^^^^ |
@PetrNovota My bad, I accidentally pushed this import.
Yes, this PR changes so the "main" dai message is saved as |
@Erol444 and what about the performance drop. Why is my FPS capped at 5FPS when its working at 20FPS without the NNData output? |
@PetrNovota depending on the model, NNData can be huge. Perhaps check its size:) |
@Erol444 I am using the model from your example:
|
@Erol444 In any case. Having the NNData store so many values and causing it such a large performance drop is not useful. What can we do about it? |
@PetrNovota please check with the ML team - I know it's possible to prune the output size/length, so eg. instead of getting 10000 detections, only get top 100. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes tested and it looks good
This returns dai.NNData objects: