Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert favicons #18

Closed
nadar opened this issue Feb 14, 2018 · 9 comments
Closed

Revert favicons #18

nadar opened this issue Feb 14, 2018 · 9 comments
Assignees
Labels

Comments

@nadar
Copy link
Member

nadar commented Feb 14, 2018

I still believe we should remove old this bloating boilerplate stuff like the different favicons.

If i am going to setup a new page (kickstart luya project) - i have to create those favicons anyhow by myself with one of those online generators - so people have to remove all those images and values from main layout - so i think this makes just no sense.

@luyadev/coredev thoughts?

@nadar nadar added the question label Feb 14, 2018
@nadar nadar changed the title Revert favions Revert favicons Feb 14, 2018
@nadar
Copy link
Member Author

nadar commented Feb 14, 2018

So i would remove all those lines including all the images, except of faivon.png like it was on 1.0.0 release.

https://github.com/luyadev/luya-kickstarter/blob/master/views/layouts/main.php#L20-L26

@dev7ch
Copy link
Contributor

dev7ch commented Feb 14, 2018

@nadar ok i agree, maybe just put a comment with a link to a favicon generator is a helpful solution

@nadar
Copy link
Member Author

nadar commented Feb 14, 2018

Where would you put this info? Not sure if this is necessary. Its basic website know-how, its not luya related.

@dev7ch
Copy link
Contributor

dev7ch commented Feb 14, 2018

e.g. views/layout/main.php ( there, where it is needed)

@nadar
Copy link
Member Author

nadar commented Feb 14, 2018

Have you seen this in any other boilerplate html templates? 😄

<!--
Put your favicons here ...
-->

@dev7ch
Copy link
Contributor

dev7ch commented Feb 14, 2018

no, but where is your pioneer spirit :)
do as you feel.

@nadar
Copy link
Member Author

nadar commented Feb 14, 2018

Less is more!

@nadar
Copy link
Member Author

nadar commented Feb 15, 2018

@dev7ch would you please take care of this issue? So we could release 1.0.1

@dev7ch
Copy link
Contributor

dev7ch commented Feb 15, 2018

@nadar sorry i am busy next days, please can you do it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants