Revision of the French translation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadar
requested changes
Jun 10, 2018
| @@ -1,6 +1,6 @@ | |||
| <?php | |||
| return [ | |||
| 'kickstarter_success' => '<h1 class="alert-heading">L\'installation s\'est terminée avec succès!</h1> | |||
| 'kickstarter_success' => '<h1 class="alert-heading">L\'installation s\'est terminée avec succès !</h1> | |||
There was a problem hiding this comment.
@arollmann Not sure if whitespace is correct before the exclamation mark? Its the only change?
There was a problem hiding this comment.
Yes, it's a detail indeed. English and German texts do not put spaces before two periods, semicolon, question mark, and exclamation point; the texts in French, yes (in France and in Belgium). Use may be different in French-speaking Switzerland and Quebec ?
nadar
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.