Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kicktstarter a bit #7

Merged
merged 3 commits into from
Jan 9, 2018
Merged

update kicktstarter a bit #7

merged 3 commits into from
Jan 9, 2018

Conversation

dev7ch
Copy link
Contributor

@dev7ch dev7ch commented Jan 9, 2018

image

@TheMaaarc TheMaaarc self-requested a review January 9, 2018 09:12
'kickstarter_success' => '<h1>Du hast es geschafft!</h1>
<p>Super, du hast es geschafft <i>LUYA</i> erfolgreich zu installieren. Du kannst dich nun in den Administrationbereich einloggen um dort deinen ersten Seiten zu erfassen.</p>
'kickstarter_success' => '<h1 class="alert-heading">Du bist bereit!</h1>
<p>Super, du hast es geschafft <i>LUYA</i> erfolgreich zu installieren. Du kannst dich nun in den Administrations-Bereich einloggen um dort deinen ersten Seiten erstellen.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"um dort deinen ersten Seiten erstellen" -> "und dort deine ersten Seiten erstellen"

@@ -1,7 +1,7 @@
<?php

return [
'kickstarter_success' => '<h1>You are done!</h1>
'kickstarter_success' => '<h1 class="alert-heading">You are ready!</h1>
<p>Yes, you have successful installed <i>LUYA</i> on your System. You are now able to login into the administration area to create your pages.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"successful" -> "successfully"
"login into" -> "log in to"

@@ -1,7 +1,7 @@
<?php

return [
'kickstarter_success' => '<h1>You are done!</h1>
'kickstarter_success' => '<h1 class="alert-heading">You are ready!</h1>
<p>Yes, you have successful installed <i>LUYA</i> on your System. You are now able to login into the administration area to create your pages.</p>
<p><strong>Important</strong><br />After loging into the administration area you have to navigation to &laquo;System&raquo; and enable all permissions for your group (Adminstrator).</p>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"loging into" -> "logging into"
"to navigation to" -> "to navigate to"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling and messages tide up will come in the next pr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just do it right the first time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coz messages need top be reranged imo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and this PR is already 'full and a bit too much changes'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you tried to say, but just remember my suggestions for when you fix those mistakes. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 i ll do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants