Corrections of PR before #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadar
requested changes
Jan 9, 2018
CHANGELOG.md
Outdated
| @@ -2,6 +2,14 @@ | |||
|
|
|||
| All notable changes to this project will be documented in this file. This project make usage of the [Yii Versioning Strategy](https://github.com/yiisoft/yii2/blob/master/docs/internals/versions.md). In order to read more about upgrading and BC breaks have a look at the [UPGRADE Document](UPGRADE.md). | |||
|
|
|||
| ## 1.0.1 (in progress) | |||
|
|
|||
| - Update lickstarter style a little bit in general | |||
There was a problem hiding this comment.
the changelog should refer to a pr or issue see an example of how we do this in general: https://github.com/luyadev/luya/blob/master/CHANGELOG.md
composer.lock
Outdated
| @@ -0,0 +1,2803 @@ | |||
| { | |||
There was a problem hiding this comment.
lock file should not commited currently, but also not in ignore list. so please remove this file for now as it contains wrong depencies
nadar
requested changes
Jan 9, 2018
CHANGELOG.md
Outdated
| @@ -2,6 +2,14 @@ | |||
|
|
|||
| All notable changes to this project will be documented in this file. This project make usage of the [Yii Versioning Strategy](https://github.com/yiisoft/yii2/blob/master/docs/internals/versions.md). In order to read more about upgrading and BC breaks have a look at the [UPGRADE Document](UPGRADE.md). | |||
|
|
|||
| ## 1.0.1 (in progress) | |||
|
|
|||
| - [#7](https://github.com/luyadev/luya-kickstarter/pull/7) Update kickstarter style a little bit in general. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update kickstarter style a little bit in general (Change to Roboto font, Replace bs3 jumbotron with card, adding favicon, adding the new LUYA logo).