Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page preview link when online but invisble. #18

Closed
nadar opened this issue Dec 25, 2017 · 0 comments
Closed

Page preview link when online but invisble. #18

nadar opened this issue Dec 25, 2017 · 0 comments
Assignees
Milestone

Comments

@nadar
Copy link
Member

nadar commented Dec 25, 2017

When previewing a CMS page which is Online but Invisible, the Websites frontend url should be used instead of the /preview url. This makes it possible to share the link with collaborators which are not logged in to the admin UI.

@nadar nadar self-assigned this Dec 25, 2017
@nadar nadar added this to the 1.0.1 milestone Dec 29, 2017
nadar added a commit that referenced this issue Dec 29, 2017
provided. This wont take any action now, as version is always provided.
#18
@nadar nadar closed this as completed in 3827f57 Jan 11, 2018
martinpetrasch pushed a commit to martinpetrasch/luya-module-cms that referenced this issue Jan 16, 2018
nadar pushed a commit that referenced this issue Jan 22, 2018
* add new translation entry for module_permission_page

* add new API controller

* add new version if switching page type without existing page versions, change return value

* change type_id when updating page type

* add template additions and directive changes for creating a new page version

* phpdoc

* Luya chinese translations (#27)

* add the chinese translations of the admin
* add the chinese translations of the frontend
* add the chinese translations of the admin
* Removed empty space

* When page is default version and online the original site path will be
used to preview the page. closes #18

* Correct drop table (#28)

* Bootstrap apply only when module exists in modules list. closes #3

* adding updated compiled js and changelog entry

* add new translation entry for module_permission_page

* add new API controller

* add new version if switching page type without existing page versions, change return value

* change type_id when updating page type

* add template additions and directive changes for creating a new page version

* adding updated compiled js and changelog entry

* adding improvements to pr

* fixed typo

* fixed psr2

* changed changelog entry to new version tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant